TYP: Update typing for 3.10 #61453
Merged
TYP: Update typing for 3.10 #61453
+177
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
commented
May 19, 2025
| @@ -140,7 +140,7 @@ repos: | |||
| pass_filenames: false | |||
| types: [python] | |||
| stages: [manual] | |||
| - id: mypy | |||
| - id: stubtest | |||
There was a problem hiding this comment.
docs indicated you could just say stubtest, but that didn't work without this change. Now you can run mypy and stubtest separately as part of type checking
Dr-Irv
commented
May 19, 2025
| @@ -563,7 +563,6 @@ def set_nulls( | |||
| if null_kind == ColumnNullType.USE_SENTINEL: | |||
| null_pos = pd.Series(data) == sentinel_val | |||
| elif null_kind in (ColumnNullType.USE_BITMASK, ColumnNullType.USE_BYTEMASK): | |||
| assert validity, "Expected to have a validity buffer for the mask" | |||
There was a problem hiding this comment.
validity cannot be None because of the test in line 558
Dr-Irv
commented
May 19, 2025
Comment on lines
+88
to
+92
| with tempfile.TemporaryDirectory() as td: | ||
| allow = os.path.join(td, "test") | ||
| with open(allow, "w+t") as allow: | ||
| allow.write("\n".join(_ALLOWLIST)) | ||
| allow.flush() |
There was a problem hiding this comment.
On Windows, creating a temporary file and leaving it open means it can't be opened by another function. The above solves that problem.
mroeschke
approved these changes
May 19, 2025
|
Thanks @Dr-Irv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyupgradeso that typing is updated to python 3.10 - that modified files inpandas/_libspandas/_typing.pyto have the following:TypeAliasto declare all typesTypeto usebuiltins.typeOptionalUnionexcept for when it is used on a pandas typeAlso fixed some other typing issues as well as an issue with running
stubtestlocally.